test setup: avoid _specification, ignored by dune#202
Open
Conversation
Author
|
The interpreter test is super slow. Any low-hanging fruit here to make our CI faster? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found that the test dependency on
_specificationdid not work, and debugged this a bit. Turns out thatdunegenerally ignores files whose name begins with_:ocaml/dune#4795
But I also found out that
dunetracks dependencies to files outside the project root fine through a symbolic link.So this PR replaces the
Makefile-generated_specificationcopy with aspecification → ../specificationsymlink. This simplifies makefiles and removes moving parts.